Include Default Worker Pool for Azure Web App targets#603
Open
benPearce1 wants to merge 2 commits into
Open
Conversation
benPearce1
changed the title
mik-ky
reviewed
May 15, 2026
Contributor
mik-ky
left a comment
mik-ky
left a comment
There was a problem hiding this comment.
First pass, one question that I'd like to understand.
| } | ||
|
|
||
| func getEndpointDetails(target *machines.DeploymentTarget) map[string]string { | ||
| func getEndpointDetails(target *machines.DeploymentTarget, opts *shared.ViewOptions) map[string]string { |
| workerPoolMap, _ := shared.GetWorkerPoolMap(opts) | ||
| return resolveValues([]string{endpoint.DefaultWorkerPoolID}, workerPoolMap)[0] | ||
| } else { | ||
| return "" |
Contributor
There was a problem hiding this comment.
nit: else is redundant and we can just return empty string without it
| } | ||
| } | ||
|
|
||
| return "N/A" |
Contributor
There was a problem hiding this comment.
I think this would return "N/A" for non azure web app targets - what about other targets that have worker pool?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #600