Adjust built in terraform step doc to better address git source use case#3074
Merged
tjnicholas merged 3 commits intomainfrom Mar 30, 2026
Merged
Adjust built in terraform step doc to better address git source use case#3074tjnicholas merged 3 commits intomainfrom
tjnicholas merged 3 commits intomainfrom
Conversation
Note ability to disable default substitution. The previous version accientally implied that variable replacement is only done with in-line and package files. I think this is a hangover from before Octopus supported Git repositories as a source. Rather than include the third third source, it seems better (assuming it is accurate) to say that substitution is always applied. Similarly, the potential for a Git source was missing from the statement about which files are substitued. Additionally, I have includes a line making it visible that the default substitution can be disabled.
Contributor
Author
|
Linting errors addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version accidentally implies that variable replacement is only done with in-line and packaged files. Earlier, the document defines three potential template sources so listing two of three implies a distinction that does not exist. I think this is a hangover from before Octopus supported Git repositories as a source.
Rather than include the third (of three) source, it seems better to say that substitution is always applied.
Similarly, the potential for a Git source was missing from the statement about which files are substituted.
I note that the current statements are not technically incorrect (as I understand it git sources are essentially converted to packages internally) but the reader of this doc can't be expected to understand that detail.
Additionally, I have includes a sentence making it clear that the default substitution can be disabled.