feat: add intersection logic to the shape structure#48
Merged
theEvilReaper merged 4 commits intodevelopfrom Mar 8, 2026
Merged
feat: add intersection logic to the shape structure#48theEvilReaper merged 4 commits intodevelopfrom
theEvilReaper merged 4 commits intodevelopfrom
Conversation
TheMeinerLP
approved these changes
Mar 6, 2026
Comment on lines
+30
to
+44
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public boolean intersect2D(Point position) { | ||
| return this.intersect3D(position); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public boolean intersect3D(Point position) { | ||
| return this.position.equals(position); | ||
| } |
Contributor
There was a problem hiding this comment.
Is there some difference?
Contributor
Author
There was a problem hiding this comment.
There is no real difference for points. Two points intersect if they share the same position, so intersect2D simply delegates to intersect3D to avoid code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Integrates the
Intersectinterface into the Shape interface to provide a unified way to check if a position intersects with a shape.Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.