fix: Unify OTEL exporter diagnostics toggle and align headers#2571
Merged
abdulraqeeb33 merged 3 commits intomainfrom Mar 12, 2026
Merged
fix: Unify OTEL exporter diagnostics toggle and align headers#2571abdulraqeeb33 merged 3 commits intomainfrom
abdulraqeeb33 merged 3 commits intomainfrom
Conversation
updated header name
added 2 commits
March 12, 2026 12:57
Contributor
📊 Diff Coverage ReportDiff Coverage Report (Changed Lines Only)Threshold: 80% Changed Files Coverage
Overall Coverage (Changed Lines Only)0/52 changed lines covered (0.0%) ❌ Coverage Check FailedFiles below 80% threshold:
|
fadi-george
approved these changes
Mar 12, 2026
fadi-george
reviewed
Mar 12, 2026
| } | ||
| } | ||
|
|
||
| override val isOtelExporterLoggingEnabled: Boolean = OTEL_EXPORTER_LOGGING_ENABLED |
Contributor
There was a problem hiding this comment.
how does isOtelExporterLoggingEnabled get set to true?
Contributor
Author
There was a problem hiding this comment.
we set it manually whenever we want to debug in our local test env.
nan-li
approved these changes
Mar 12, 2026
|
|
||
| val extraHttpHeaders: Map<String, String> by lazy { | ||
| mapOf( | ||
| "X-OneSignal-App-Id" to appId, |
Contributor
There was a problem hiding this comment.
we don't need app_id in header anymore because it's already captured elsewhere right
abdulraqeeb33
added a commit
that referenced
this pull request
Mar 12, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./gradlew :OneSignal:otel:test./gradlew :OneSignal:otel:compileDebugKotlinorigin/mainonly includes OTEL/header and platform-provider toggle wiring changes