chore: Fix demo build.gradle.kts and improve Red App getting started docs#2574
Merged
abdulraqeeb33 merged 2 commits intomainfrom Mar 12, 2026
Merged
chore: Fix demo build.gradle.kts and improve Red App getting started docs#2574abdulraqeeb33 merged 2 commits intomainfrom
abdulraqeeb33 merged 2 commits intomainfrom
Conversation
added 2 commits
March 12, 2026 16:20
Move the `kotlinVersion` extra property inside `buildscript {}` so it is
visible when the classpath dependency is resolved. Update GettingStarted.md
to document the actual file path for changing the App ID and add a bold
warning that the change requires a reinstall.
Made-with: Cursor
Contributor
📊 Diff Coverage Report✓ Coverage check passed (no source files changed) |
abdulraqeeb33
changed the title
nan-li
approved these changes
Mar 12, 2026
Contributor
nan-li
left a comment
nan-li
left a comment
There was a problem hiding this comment.
LGTM - we could add Clear All notifications, or not, these changes are fine as is
Contributor
Author
I get another PR for the clear notifications @nan-li . I want to get this out as its critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix kotlinVersion scope in demo build.gradle.kts and improve App ID docs in GettingStarted.md.
Details
Motivation
The demo app's root
build.gradle.ktsdefinedkotlinVersionoutsidebuildscript {}, making it invisible during classpath resolution. Additionally, the getting started guide didn't document the actual file path for changing the App ID or warn that a reinstall is required.Scope
examples/demo/build.gradle.kts— Movedval kotlinVersion by extra("2.2.0")inside thebuildscript {}block so the Kotlin Gradle plugin classpath dependency can resolve it.examples/demo/GettingStarted.md— Added a bold warning that changing the App ID requires uninstalling and reinstalling the app. Documented the actual file path (app/src/main/res/values/strings.xml) with an XML snippet.Testing
Unit testing
N/A — build config fix and documentation-only change, no app code modified.
Manual testing
Verified Gradle sync succeeds after the
build.gradle.ktsfix. Confirmed all referenced paths and instructions in the doc are accurate.Affected code checklist
None of the above are affected.
Checklist
Overview
Testing
Final pass
Made with Cursor