Skip to content

Follow-up: normalize Tauri before-command script paths#183

Merged
Jordonbc merged 1 commit intoDevfrom
codex/github-mention-build-script-issue
Mar 19, 2026
Merged

Follow-up: normalize Tauri before-command script paths#183
Jordonbc merged 1 commit intoDevfrom
codex/github-mention-build-script-issue

Conversation

@Jordonbc
Copy link
Collaborator

Motivation

  • Fix an inconsistent relative path in Backend/tauri.conf.json so Tauri's beforeDevCommand and beforeBuildCommand both resolve from the Backend/ directory in local development and CI workflows.

Description

  • Updated Backend/tauri.conf.json by changing beforeDevCommand from node ../Backend/scripts/run-tauri-before-command.js dev to node scripts/run-tauri-before-command.js dev so it matches the existing beforeBuildCommand path.

Testing

  • Validated the modified JSON with python -m json.tool Backend/tauri.conf.json, which succeeded.

Codex Task

@github-actions
Copy link

PR Review: Follow-up: normalize Tauri before-command script paths

Summary

A minimal, correct fix that aligns beforeDevCommand path convention with beforeBuildCommand.

Changes (Backend/tauri.conf.json)

- "beforeDevCommand": "node ../Backend/scripts/run-tauri-before-command.js dev"
+ "beforeDevCommand": "node scripts/run-tauri-before-command.js dev"

Assessment

Code Quality: ✓ Clean, isolated change. No issues.

Correctness: ✓ The old path ../Backend/scripts/... was inconsistent:

  • Tauri resolves paths relative to tauri.conf.json location (Backend/)
  • beforeBuildCommand already used the correct scripts/... path
  • The old path created an unnecessary parent-then-back traversal

Potential Bugs: None. The fix resolves a real path resolution bug.

Testing: JSON validation is appropriate for config changes.

Minor Suggestion: Consider adding a runtime test (e.g., verify cargo tauri dev starts successfully) to catch config issues earlier. However, for a one-line path fix, the current testing is sufficient.

LGTM - Ship it.

New%20session%20-%202026-03-19T03%3A48%3A27.139Z
opencode session  |  github run

@Jordonbc Jordonbc merged commit 39c40c7 into Dev Mar 19, 2026
7 checks passed
@Jordonbc Jordonbc deleted the codex/github-mention-build-script-issue branch March 19, 2026 03:54
Jordonbc added a commit that referenced this pull request Mar 19, 2026
Merge pull request #183 from Open-VCS/codex/github-mention-build-script-issue

Follow-up: normalize Tauri before-command script paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant