Skip to content

Merge pull request #183 from Open-VCS/codex/github-mention-build-script-issue Follow-up: normalize Tauri before-command script paths#184

Merged
Jordonbc merged 2 commits intostablefrom
Dev
Mar 19, 2026
Merged

Merge pull request #183 from Open-VCS/codex/github-mention-build-script-issue Follow-up: normalize Tauri before-command script paths#184
Jordonbc merged 2 commits intostablefrom
Dev

Conversation

@Jordonbc
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Code Review Summary

Changes Made

The PR normalizes the beforeDevCommand and beforeBuildCommand paths in Backend/tauri.conf.json by removing the redundant ../Backend/ prefix.

Analysis

Bug Fix / Correctness:

  • The old paths ../Backend/scripts/... were problematic: from the Backend directory, .. goes to the project root, then Backend/ goes back into Backend - this is redundant and confusing
  • The new paths scripts/... are correctly relative to the Backend directory where Tauri runs

Potential Issues:

  1. Verifiability: The change appears correct (script exists at Backend/scripts/run-tauri-before-command.js), but it should be tested by running cargo tauri dev to confirm the before-command script executes properly
  2. Consistency: This appears to be a follow-up fix - worth checking if similar path issues exist elsewhere in the config

Code Quality:

  • Clean, minimal change
  • No new linting or type issues introduced

Recommendation

The change is correct and resolves a path inconsistency. It should work properly when running Tauri commands from the Backend directory. No issues found - this looks ready to merge pending runtime verification.

New%20session%20-%202026-03-19T03%3A54%3A14.228Z
opencode session  |  github run

@Jordonbc Jordonbc merged commit 2621d33 into stable Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant