-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Fix 23034 - child constructor no longer has invalid access to parent field #23043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hugin78
wants to merge
4
commits into
OpenAPITools:master
from
hugin78:fix-23034-microprofile-readonly-parent-invalid-code
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3cb3f2
Fix fix that child constructor was invalid when having readonly field…
hugin78bankdata 9156902
add classType field
hugin78bankdata eb40215
fix test
hugin78bankdata 4bf2e30
Merge branch 'master' into fix-23034-microprofile-readonly-parent-inv…
hugin78bankdata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
modules/openapi-generator/src/test/resources/bugs/issue_23034.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| --- | ||
| openapi: 3.0.4 | ||
| info: | ||
| title: Reproduce | ||
| version: 'v1' | ||
| components: | ||
| schemas: | ||
| Child: | ||
| required: | ||
| - childField1 | ||
| type: object | ||
| allOf: | ||
| - $ref: "#/components/schemas/Parent" | ||
| properties: | ||
| childField1: | ||
| type: string | ||
|
|
||
| Parent: | ||
| required: | ||
| - classType | ||
| - parentField | ||
| type: object | ||
| properties: | ||
| parentField: | ||
| type: string | ||
| readOnly: true | ||
| classType: | ||
| description: Identifier of discriminator mapping class. | ||
| enum: | ||
| - Child | ||
| type: string | ||
| discriminator: | ||
| propertyName: classType | ||
| mapping: | ||
| Child: "#/components/schemas/Child" | ||
| paths: | ||
| '/v1/reproduce': | ||
| get: | ||
| responses: | ||
| '200': | ||
| content: | ||
| application/json: | ||
| schema: | ||
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/Child' | ||
| description: 'reproduce' | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.