Skip to content

build: Pin Develocity Maven extension version in pom.xml.#23326

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
commiterate:pin_develocity
Mar 24, 2026
Merged

build: Pin Develocity Maven extension version in pom.xml.#23326
wing328 merged 1 commit intoOpenAPITools:masterfrom
commiterate:pin_develocity

Conversation

@commiterate
Copy link
Copy Markdown
Contributor

@commiterate commiterate commented Mar 23, 2026

The Develocity Maven extension version is pinned in .mvn/extensions.xml but not pom.xml. This causes Maven build to pull the latest extension version which breaks reproducible builds.

NixOS/nixpkgs#483728 (comment)

(cc: @wing328)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@wing328 wing328 merged commit ff66e1b into OpenAPITools:master Mar 24, 2026
16 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Mar 24, 2026
@commiterate commiterate deleted the pin_develocity branch March 24, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants