Skip to content

[Kotlin] Replace deprecated Ktor base64 encoding with Kotlin std library call #23345

Merged
wing328 merged 3 commits intomasterfrom
rlnt-ktor-deprecation
Mar 25, 2026
Merged

[Kotlin] Replace deprecated Ktor base64 encoding with Kotlin std library call #23345
wing328 merged 3 commits intomasterfrom
rlnt-ktor-deprecation

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Mar 25, 2026

based on #23334 with updated samples

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Replace deprecated io.ktor.util.encodeBase64 with Kotlin stdlib kotlin.io.encoding.Base64 in Kotlin client templates and samples. This removes deprecation warnings and future-proofs generated clients, and fixes #22808.

Written for commit 369e6ea. Summary will update on new commits.

@wing328 wing328 added this to the 7.22.0 milestone Mar 25, 2026
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Mar 25, 2026
@wing328 wing328 changed the title Rlnt ktor deprecation [Kotlin] Replace deprecated Ktor base64 encoding with Kotlin std library call Mar 25, 2026
@wing328 wing328 marked this pull request as ready for review March 25, 2026 06:48
@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Mar 25, 2026

kotlin sample tests passed

@wing328 wing328 merged commit 7ad8951 into master Mar 25, 2026
87 of 90 checks passed
@wing328 wing328 deleted the rlnt-ktor-deprecation branch March 25, 2026 06:48
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Kotlin Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: General

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[KOTLIN][BUG] Ktor deprecation for authentication

2 participants