Skip to content

Add scalafmt plugin to scala-sttp4-jsoniter client generator#23378

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
YB0y:feat/scala-sttp4-jsoniter-scalafmt
Mar 31, 2026
Merged

Add scalafmt plugin to scala-sttp4-jsoniter client generator#23378
wing328 merged 2 commits intoOpenAPITools:masterfrom
YB0y:feat/scala-sttp4-jsoniter-scalafmt

Conversation

@YB0y
Copy link
Copy Markdown
Contributor

@YB0y YB0y commented Mar 27, 2026

Adds scalafmt (Scalafmt 3.10.6, Scala 2.13 dialect) and sbt-scalafmt plugin (2.5.6) to the scala-sttp4-jsoniter client generator, following the same pattern as #23273 (scala-sttp4).

Part of #23274

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    Commit all changed files.
  • File the PR against the correct branch: master
  • If your PR solves a reported issue, reference it using GitHub's linking syntax
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds Scalafmt support to the scala-sttp4-jsoniter client generator for consistent Scala formatting across generated projects. Regenerates samples after rebase. Part of #23274.

  • New Features
    • Generator emits .scalafmt.conf (Scalafmt 3.10.6, Scala 2.13) and adds sbt-scalafmt plugin (2.5.6) via project/plugins.sbt using scalafmt.mustache and project/plugins.mustache.
    • Updated Petstore scala-sttp4-jsoniter sample to include the new files; other samples refreshed by regen.

Written for commit b6c44f8. Summary will update on new commits.

@YB0y YB0y force-pushed the feat/scala-sttp4-jsoniter-scalafmt branch from b585253 to 134eaff Compare March 27, 2026 12:31
@YB0y YB0y force-pushed the feat/scala-sttp4-jsoniter-scalafmt branch from 134eaff to b6c44f8 Compare March 27, 2026 13:14
@YB0y
Copy link
Copy Markdown
Contributor Author

YB0y commented Mar 27, 2026

Hi @wing328 Could you please help me with passing CI test?
How can I address Samples up-to-date CI test failure?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 27, 2026

don't worry. i'll take care of it later

@YB0y
Copy link
Copy Markdown
Contributor Author

YB0y commented Mar 30, 2026

@wing328 Sorry for the ping. When you have time, could you take a look at this? I’d appreciate your help getting the CI tests passing and moving this toward a merge.

@wing328 wing328 merged commit ab17676 into OpenAPITools:master Mar 31, 2026
55 of 56 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants