Skip to content

feat(dart-dio): add methods to remove auth tokens in api client#23386

Open
nopjar wants to merge 1 commit intoOpenAPITools:masterfrom
nopjar:master
Open

feat(dart-dio): add methods to remove auth tokens in api client#23386
nopjar wants to merge 1 commit intoOpenAPITools:masterfrom
nopjar:master

Conversation

@nopjar
Copy link
Copy Markdown

@nopjar nopjar commented Mar 28, 2026

There is currently no way to easily remove a previously set auth token. Adding these methods will provide a convenient way to 'revoke' tokens.

Design-Choice:
Adding those new methods is a better alternative as just making the values of existing methods nullable, as e.g. #setBasicAuth(String, String, String) has two value parameters, which then would have to be checked for nullability and special handling would be required if only one value is null. This would result in a less clear API. By adding new methods following the naming #removeXY(String) no ambiguity is added and a clear API is kept.

Output was tested and is working as expected.

Mentions as this only targets Dart code (like required in the PR checklist): @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Added removal methods for auth credentials in dart-dio API clients so apps can revoke tokens/keys at runtime without recreating the client.

  • New Features
    • removeOAuthToken(name) removes tokens from OAuthInterceptor.
    • removeBearerAuth(name) removes tokens from BearerAuthInterceptor.
    • removeBasicAuth(name) removes credentials from BasicAuthInterceptor.
    • removeApiKey(name) removes keys from ApiKeyAuthInterceptor.

Written for commit 76736b2. Summary will update on new commits.

There is currently no way to easily remove a previously set auth token.
Adding these methods will provide a convenient way to 'revoke' tokens.

Design-Choice:
Adding those new methods is a better alternative as just making the values of existing methods nullable, as e.g. #setBasicAuth(String, String, String) has two value parameters, which then would have to be checked for nullability and special handling would be required if only one value is null.
This would result in a less clear API. By adding new methods following the naming #removeXY(String) no ambiguity is added and a clear API is kept.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant