build(deps): bump serialize-javascript and @angular-devkit/build-angular in /samples/client/petstore/typescript-angular-v19#23393
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 7.0.5 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `serialize-javascript` from 6.0.2 to 7.0.5 - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v6.0.2...v7.0.5) Updates `@angular-devkit/build-angular` from 19.0.2 to 21.2.5 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@19.0.2...v21.2.5) --- updated-dependencies: - dependency-name: serialize-javascript dependency-version: 7.0.5 dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-version: 21.2.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/typescript-angular-v19/package.json">
<violation number="1" location="samples/client/petstore/typescript-angular-v19/package.json:26">
P1: This bumps `@angular-devkit/build-angular` to v21 while the project remains on Angular v19/TypeScript 5.6, creating incompatible peer requirements.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "^19.0.2", | ||
| "@angular-devkit/build-angular": "^21.2.5", |
Contributor
There was a problem hiding this comment.
P1: This bumps @angular-devkit/build-angular to v21 while the project remains on Angular v19/TypeScript 5.6, creating incompatible peer requirements.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/typescript-angular-v19/package.json, line 26:
<comment>This bumps `@angular-devkit/build-angular` to v21 while the project remains on Angular v19/TypeScript 5.6, creating incompatible peer requirements.</comment>
<file context>
@@ -23,7 +23,7 @@
},
"devDependencies": {
- "@angular-devkit/build-angular": "^19.0.2",
+ "@angular-devkit/build-angular": "^21.2.5",
"@angular/cli": "^21.1.0",
"@angular/compiler-cli": "^19.0.0",
</file context>
Suggested change
| "@angular-devkit/build-angular": "^21.2.5", | |
| "@angular-devkit/build-angular": "^19.0.2", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps serialize-javascript to 7.0.5 and updates ancestor dependency @angular-devkit/build-angular. These dependencies need to be updated together.
Updates
serialize-javascriptfrom 6.0.2 to 7.0.5Release notes
Sourced from serialize-javascript's releases.
... (truncated)
Commits
df3f1c1release: v7.0.5f147e90Merge commit from forkeec32e0release: v7.0.4d5057157.0.32e609d0fix(CVE-2020-7660): fix for RegExp.flags and Date.prototype.toISOString (#207)42b7cdbbuild(deps-dev): bump lodash from 4.17.21 to 4.17.23 (#206)44f544brelease: v7.0.2 (#205)bba0dddci: setup trusted publishing workflow (#204)235f6eaci: bump GitHub Actions to latest versions (#203)f7fff15release: v7.0.1 (#202)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for serialize-javascript since your current version.
Updates
@angular-devkit/build-angularfrom 19.0.2 to 21.2.5Release notes
Sourced from
@angular-devkit/build-angular's releases.... (truncated)
Changelog
Sourced from
@angular-devkit/build-angular's changelog.... (truncated)
Commits
3018612release: cut the v21.2.5 release349bd43build: update dependency picomatch to v4.0.4cadf9b2feat(@angular/cli): support custom port in MCP devserver start toolbbc2554fix(@angular/ssr): allow underscores in host validation88ac998build: update cross-repo angular dependencies022e0efbuild: update github/codeql-action action to v4.34.1c363f19build: update dependency node to v22.22.2b1fe66afix(@angular/ssr): patch Headers.forEach in cloneRequestAndPatchHeaders2aa93fcrelease: cut the v21.2.4 releasef33826ebuild: update cross-repo angular dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by cubic
Updates the Angular sample’s build stack and serialization dependency to pick up fixes and stay current. Bumps
@angular-devkit/build-angularto 21.2.5 andserialize-javascriptto 7.0.5.Dependencies
@angular-devkit/build-angular: 19.0.2 → 21.2.5 (build/test fixes and CLI improvements).serialize-javascript: 6.0.2 → 7.0.5 (security and performance fixes). Updated together for compatibility.Migration
Written for commit a4229e8. Summary will update on new commits.