fixes(spring) Fixes @Nullable annotation#23397
fixes(spring) Fixes @Nullable annotation#23397antechrestos wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
* remove findbug dependency as spring generator set its import to 'org.springframework.lang.Nullable' * for springboot 4, use 'org.jspecify.annotations.Nullable' as spring one is Deprecated
|
@cachescrubber @wing328 I need you memory on this subject. I would like to use As jspecify I though that a good workaround could be to add an Yet I looked at the history and ended on your modification @cachescrubber . As I do not understand very well reason why this revert, and, whether it is needed todays, I am asking your help to understand that before pushing a bug. Thank you by advance |
|
@antechrestos @wing328 #23256 fixes it ([java] [Spring] useJspecify for java clients and spring generator). It works except for an issue with github workflows. An access Denied that I don't know how to fix. Please help on that. |
|
@jpfinne I think I found your right issue on your PR. Please take a look at my comment |
org.springframework.lang.Nullableorg.jspecify.annotations.Nullableas spring one isDeprecated(see java doc)PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes @nullable handling in Spring generators: use
org.jspecify.annotations.Nullablefor Spring Boot 4 andorg.springframework.lang.Nullableotherwise. Removesjsr305from generated POMs to avoid deprecated annotations and keep builds clean.Bug Fixes
Nullablebased on Spring Boot version (SB4->org.jspecify.annotations.Nullable, elseorg.springframework.lang.Nullable).Dependencies
com.google.code.findbugs:jsr305from Spring Boot, Spring Cloud, and HTTP Interface templates; updated samples to match.Written for commit b2b3076. Summary will update on new commits.