[PYTHON][bugfix] Fix missing post-params when content type is json#23526
Open
ilayu-blip wants to merge 3 commits intoOpenAPITools:masterfrom
Open
[PYTHON][bugfix] Fix missing post-params when content type is json#23526ilayu-blip wants to merge 3 commits intoOpenAPITools:masterfrom
ilayu-blip wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/python/tornado/rest.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/python/tornado/rest.mustache:125">
P2: Truthy check overrides explicit falsy JSON bodies; should only fallback when body is None.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
modules/openapi-generator/src/main/resources/python/tornado/rest.mustache
Outdated
Show resolved
Hide resolved
e43edda to
fc9b7ea
Compare
Member
|
please follow step 3 to update the samples so as to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/24349292681/job/71112564228?pr=23526 |
Contributor
There was a problem hiding this comment.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".gitignore">
<violation number="1" location=".gitignore:314">
P2: Overbroad `.gitignore` pattern `?/` ignores any single-character directory instead of a specific generated artifact.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #23457
I have made the fix to be non-destructive. If this issue did not happen to you then this fix will not BREAK anything.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)
Summary by cubic
Fixes missing
post_paramsfor JSON requests in Python clients by sending them as the JSON payload whenbodyis empty. Also updates.gitignoreto ignore artifacts fromrun-in-docker.sh(refs #23457).Bug Fixes
python/asyncio,python/tornado,python/httpx,python-pydantic-v1/asyncio,python-pydantic-v1/tornado,python-pydantic-v1; regenerated Python samples to match.json.dumps(...)orargs["json"], usingdict(post_params)whenbody is None.Misc
.gitignoreto excluderun-in-docker.shgenerated artifacts.Written for commit 5719862. Summary will update on new commits.