fix: align trace report test assertions with reset-step behavior#141
Merged
fix: align trace report test assertions with reset-step behavior#141
Conversation
The test_report_with_trajectory test expected trajectory data from step_index=0 to appear in the report, but generate_trace_report.py skips trajectory metadata for Step 0 (Reset) by design. Updated assertions to match the actual report output: step_index=0 data is absent, while step_index=1 and 2 data appears correctly under Steps 1 and 2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_report_with_trajectorythat has been breaking thetestworkflow since PR feat: add execution trace report generator #138 introducedgenerate_trace_report.pystep_index=0to appear in the report, but the script intentionally skips trajectory metadata for Step 0 (the Reset step) -- it renders## Step 0 (Reset)with only the screenshot andcontinues past trajectory datastep_index=0data is absent, andstep_index=1/step_index=2data is correctly rendered under Steps 1 and 2Test plan
test_report_with_trajectorypasses locallytest_generate_trace_report.pypasstestworkflow passes on this PR🤖 Generated with Claude Code