Implement scope checking in the existing attribute validator#1298
Draft
Implement scope checking in the existing attribute validator#1298
Conversation
Advantages: - makes use of existing Engineblock facility - vastly reduces code duplication - makes it configurable which attributes are subject to the check - makes it configurable which attributes will block vs which will only log - makes it possible to display scope violation in the debug page already Todo: - Improve exception message to indicate cause of blockage - Integrate into debug page - Remove now unused previous code
Member
|
@thijskh Is there an issue that describes what you are trying to achieve here? From the code, I sort of understand what you're trying to do, but I'm not sure which functionality it is that you are replacing here (which seems to be the goal, going from the "Advantages" in the description). |
Member
Author
|
Replaces the current separate Scope check filters in the EB processing pipeline which are not very configurable. Might revive this PR when I would have a working EB development environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advantages:
Todo: