Issue-1989 apply rector rules for 8.5#2001
Open
kayjoosten wants to merge 5 commits into
Open
Conversation
Applied all rector rules safe for the codebase: - AddTypeToConstRector: typed class constants throughout - AddOverrideAttributeToOverriddenMethodsRector / Properties: #[Override] - ArrayKeyExistsNullToEmptyStringRector: cast keys to string - PushRequestToRequestStackConstructorRector: updated test setup - ArrayFirstLastRector, ForeachToArrayAnyRector: PHP 8.5 builtins - FunctionFirstClassCallableRector / ArrowFunctionDelegatingCallToFirstClassCallableRector - RemoveFuncCallRector: removed deprecated xml_parser_free() - SleepToSerializeRector: converted __sleep/__wakeup to __serialize/__unserialize, with manual fixes to preserve XML reconstruction logic in four decorators Added to rector.php skip list: - NewMethodCallWithoutParenthesesRector: PHP 8.4 syntax unsupported by PHPMD/pdepend - DeprecatedAnnotationToDeprecatedAttributeRector: #[Deprecated] emits runtime E_DEPRECATED notices causing PHPUnit risky failures (failOnRisky=true)
…catedAttributeRector skipped The #[Deprecated] PHP 8.5 attribute emits E_DEPRECATED at runtime, causing PHPUnit risky failures (failOnRisky=true). Rule added to rector.php skip list; affected files restored to their state on main.
Library files have no namespace declaration so \Override is equivalent to Override; use the unqualified form for consistency with src/ files.
kayjoosten
changed the title
- Remove unnecessary intermediate variable in Bindings::hasEncryptedAssertion - Add __unserialize() to X509CertificateLazyProxy to match __serialize() - Type public const USED_DISCOVERY_HASH_PARAM as string in DiscoverySelectionService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.