Skip to content

[patina_internal_cpu] remove alloc usage#1423

Merged
kuqin12 merged 26 commits intoOpenDevicePartnership:mainfrom
kuqin12:bu3
Mar 26, 2026
Merged

[patina_internal_cpu] remove alloc usage#1423
kuqin12 merged 26 commits intoOpenDevicePartnership:mainfrom
kuqin12:bu3

Conversation

@kuqin12
Copy link
Copy Markdown
Contributor

@kuqin12 kuqin12 commented Mar 20, 2026

Description

Patina internal CPU hosts the interrupt manager and other fundamental functionalities, which should not work on top of the allocator.

Admittedly, the current crate can support more advanced components that works on top of exception forwarding, but this should not be treated as a required dependency.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested on QEMU Q35 and booted to UEFI shell.

Integration Instructions

N/A

@patina-automation
Copy link
Copy Markdown
Contributor

patina-automation Bot commented Mar 20, 2026

✅ QEMU Validation Passed

All QEMU validation jobs completed successfully.

Note: Q35 is only built on Windows hosts (QEMU boot is disabled due to a QEMU vfat issue).

Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/23568436131

Boot Time to EFI Shell

Platform Elapsed
Q35 (Linux Host) 28.3s
SBSA (Linux Host) 35.0s

Dependencies

Repository Ref
patina 9e10c71
patina-dxe-core-qemu 4f98fff
patina-fw-patcher 3b8900d
patina-qemu firmware v2.0.0
patina-qemu build script da1e895

This comment was automatically generated by the Patina QEMU PR Validation Post workflow.

Comment thread core/patina_internal_cpu/src/paging/null.rs Outdated
Comment thread core/patina_internal_cpu/src/paging/x64.rs Outdated
Comment thread core/patina_internal_cpu/src/paging.rs
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/patina_internal_cpu/src/paging/aarch64.rs 0.00% 2 Missing ⚠️
core/patina_internal_cpu/src/paging/x64.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@kuqin12 kuqin12 marked this pull request as ready for review March 24, 2026 00:10
@kuqin12 kuqin12 requested review from cfernald and os-d March 24, 2026 00:10
Comment thread core/patina_internal_cpu/src/cpu/stub.rs Outdated
Comment thread core/patina_internal_cpu/src/cpu/aarch64/cpu.rs Outdated
Comment thread core/patina_internal_cpu/src/lib.rs Outdated
Comment thread core/patina_internal_cpu/src/lib.rs
@kuqin12 kuqin12 merged commit 139ff1c into OpenDevicePartnership:main Mar 26, 2026
10 checks passed
@kuqin12 kuqin12 deleted the bu3 branch March 26, 2026 04:33
kuqin12 added a commit that referenced this pull request Mar 26, 2026
## Description

The previous
[PR](#1423) merged
with intermittent testing stability: when the tests are run
concurrently, some tests could fail based on timing. i.e.:

https://github.com/OpenDevicePartnership/patina/actions/runs/23577664570/job/68653514272#step:5:1395

The idea is to put a lock on the test and extend the test to register
and unregister within each individual test.

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [x] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

This was tested locally and on the pipeline to not trip on the same
error.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants