Skip to content

Email notifications upon task completion#354

Merged
annehaley merged 10 commits intomasterfrom
email-notifs
Mar 19, 2026
Merged

Email notifications upon task completion#354
annehaley merged 10 commits intomasterfrom
email-notifs

Conversation

@annehaley
Copy link
Copy Markdown
Collaborator

Resolves #127

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying geodatalytics with  Cloudflare Pages  Cloudflare Pages

Latest commit: f324956
Status: ✅  Deploy successful!
Preview URL: https://ef0b1d41.geodatalytics.pages.dev
Branch Preview URL: https://email-notifs.geodatalytics.pages.dev

View logs

@annehaley annehaley requested a review from BryonLewis March 16, 2026 16:57
Comment thread uvdat/core/models/task_result.py Outdated
Comment thread uvdat/core/models/task_result.py Outdated
Comment thread uvdat/core/models/task_result.py
Comment thread uvdat/core/rest/analytics.py Outdated
@brianhelba
Copy link
Copy Markdown
Collaborator

If you want to write a test for this endpoint, be aware you have access to the fixture: https://pytest-django.readthedocs.io/en/latest/helpers.html#mailoutbox

Testing is already configured to capture emails otherwise.

@annehaley
Copy link
Copy Markdown
Collaborator Author

If you want to write a test for this endpoint, be aware you have access to the fixture: https://pytest-django.readthedocs.io/en/latest/helpers.html#mailoutbox

Great idea, added tests in d3fa8f0

@annehaley annehaley requested a review from brianhelba March 17, 2026 21:29
Comment thread uvdat/core/models/task_result.py Outdated
Comment thread uvdat/core/tests/test_analytics.py Outdated
Comment thread uvdat/core/tests/test_analytics.py Outdated
Comment thread uvdat/core/rest/analytics.py Outdated
Comment thread uvdat/core/models/task_result.py
Copy link
Copy Markdown
Collaborator

@brianhelba brianhelba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more issues (one I didn't notice before), otherwise looks good.

Co-authored-by: Brian Helba <brian.helba@kitware.com>
Copy link
Copy Markdown
Collaborator

@brianhelba brianhelba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. :shipit:

@annehaley annehaley merged commit e8fe85e into master Mar 19, 2026
3 checks passed
@annehaley annehaley deleted the email-notifs branch March 19, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable email notifications for task completion

2 participants