Conversation
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable - works but raises pragmatism questions
The implementation is solid and tests are thorough. However, the diff doesn't show adding rich to dependencies. Either it's missing or already available transitively. The architectural decision to use rich for a banner (if it's a NEW dependency) is worth discussing - are we adding a library for cosmetic output that prints once per session?
|
Thanks @VascoSch92 ! @rbren -- you good with this update? |
We do have |
There was a problem hiding this comment.
Re: "sdkbuilders.openhands.dev", sorry this is a surprise, I had no idea about it.
I asked a tiny question in the linked issue, and the more I think about it, I'm a bit torn here:
- it's cool to use subdomains for sure (I didn't understand why we were trying to cram the entire surface in only like three tabs, subdomains sound great),
- but it seems strange to use a subdomain for the sdk.
How about:
- openhands.dev are the main Open Source projects (the SDK, the CLI, docs page with use cases probably fits too)
- enterprise.openhands.dev is enterprise
Alternatively,
- openhands.dev is the SDK
- can maybe also fit use cases, with links to everything
- apps.openhands.dev CLI, web, probably Cloud; others
- enterprise.openhands.dev enterprise
If I may put it simply, OpenHands is the project whose vision is to build agentic technology in the open, for everyone. Then, applications are built on it.
Most projects out there are named as they are named.
The name of this project is OpenHands. 😄
And they name enteprise 'enterprise'. Everyone knows what to expect if they see 'enterprise that way'. 😅
|
Actually, alternatively, just for clarity:
There are links between them etc. I think maybe this story is more faithful, WDYT? |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
1 similar comment
|
[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
Hey Just let me know and I would do the relative changes |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
1 similar comment
|
[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
Summary
ref. #2481
Let me know if you like it.
You can actually click the link if your terminal support hyperlinks.
Checklist
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:39794c4-pythonRun
All tags pushed for this build
About Multi-Architecture Support
39794c4-python) is a multi-arch manifest supporting both amd64 and arm6439794c4-python-amd64) are also available if needed