Skip to content

feat(sdk): new banner#2539

Open
VascoSch92 wants to merge 2 commits intomainfrom
vasco/update-banner
Open

feat(sdk): new banner#2539
VascoSch92 wants to merge 2 commits intomainfrom
vasco/update-banner

Conversation

@VascoSch92
Copy link
Copy Markdown
Contributor

@VascoSch92 VascoSch92 commented Mar 20, 2026

Summary

ref. #2481

Let me know if you like it.

You can actually click the link if your terminal support hyperlinks.

Screenshot 2026-03-20 at 17 14 25

Checklist

  • If the PR is changing/adding functionality, are there tests to reflect this?
  • If there is an example, have you run the example to make sure that it works?
  • If there are instructions on how to run the code, have you followed the instructions and made sure that it works?
  • If the feature is significant enough to require documentation, is there a PR open on the OpenHands/docs repository with the same branch name?
  • Is the github CI passing?

Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.13-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:39794c4-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-39794c4-python \
  ghcr.io/openhands/agent-server:39794c4-python

All tags pushed for this build

ghcr.io/openhands/agent-server:39794c4-golang-amd64
ghcr.io/openhands/agent-server:39794c4-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:39794c4-golang-arm64
ghcr.io/openhands/agent-server:39794c4-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:39794c4-java-amd64
ghcr.io/openhands/agent-server:39794c4-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:39794c4-java-arm64
ghcr.io/openhands/agent-server:39794c4-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:39794c4-python-amd64
ghcr.io/openhands/agent-server:39794c4-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-amd64
ghcr.io/openhands/agent-server:39794c4-python-arm64
ghcr.io/openhands/agent-server:39794c4-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-arm64
ghcr.io/openhands/agent-server:39794c4-golang
ghcr.io/openhands/agent-server:39794c4-java
ghcr.io/openhands/agent-server:39794c4-python

About Multi-Architecture Support

  • Each variant tag (e.g., 39794c4-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., 39794c4-python-amd64) are also available if needed

@VascoSch92 VascoSch92 requested review from jpelletier1 and rbren March 20, 2026 16:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2026

Python API breakage checks — ✅ PASSED

Result:PASSED

Action log

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2026

REST API breakage checks (OpenAPI) — ✅ PASSED

Result:PASSED

Action log

Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taste Rating: 🟡 Acceptable - works but raises pragmatism questions

The implementation is solid and tests are thorough. However, the diff doesn't show adding rich to dependencies. Either it's missing or already available transitively. The architectural decision to use rich for a banner (if it's a NEW dependency) is worth discussing - are we adding a library for cosmetic output that prints once per session?

Comment thread openhands-sdk/openhands/sdk/banner.py
Comment thread openhands-sdk/openhands/sdk/banner.py
Comment thread tests/sdk/test_banner.py
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL21969632471% 
report-only-changed-files is enabled. No files were changed during this commit :)

@jpelletier1
Copy link
Copy Markdown
Contributor

Thanks @VascoSch92 !

@rbren -- you good with this update?

@VascoSch92
Copy link
Copy Markdown
Contributor Author

The implementation is solid and tests are thorough. However, the diff doesn't show adding rich to dependencies. Either it's missing or already available transitively. The architectural decision to use rich for a banner (if it's a NEW dependency) is worth discussing - are we adding a library for cosmetic output that prints once per session?

We do have rich declared in the pyproject of software-agent-sdk

Copy link
Copy Markdown
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: "sdkbuilders.openhands.dev", sorry this is a surprise, I had no idea about it.

I asked a tiny question in the linked issue, and the more I think about it, I'm a bit torn here:

  • it's cool to use subdomains for sure (I didn't understand why we were trying to cram the entire surface in only like three tabs, subdomains sound great),
  • but it seems strange to use a subdomain for the sdk.

How about:

  • openhands.dev are the main Open Source projects (the SDK, the CLI, docs page with use cases probably fits too)
  • enterprise.openhands.dev is enterprise

Alternatively,

  • openhands.dev is the SDK
    • can maybe also fit use cases, with links to everything
  • apps.openhands.dev CLI, web, probably Cloud; others
  • enterprise.openhands.dev enterprise

If I may put it simply, OpenHands is the project whose vision is to build agentic technology in the open, for everyone. Then, applications are built on it.

Most projects out there are named as they are named.
The name of this project is OpenHands. 😄

And they name enteprise 'enterprise'. Everyone knows what to expect if they see 'enterprise that way'. 😅

@enyst
Copy link
Copy Markdown
Collaborator

enyst commented Mar 22, 2026

Actually, alternatively, just for clarity:

  • openhands.dev documents the Open Source project
    • the OpenHands agent, designed as an SDK for people to build upon
    • openhands index - benchmarks performance
    • CLI - an easy interface, to use the agent
    • others maybe
  • app.all-hands.dev is the Cloud
  • enterprise.all-hands.dev documents the enterprise business
    • and presumably hosts support, billing, etc.

There are links between them etc. I think maybe this story is more faithful, WDYT?

@all-hands-bot
Copy link
Copy Markdown
Collaborator

[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

1 similar comment
@all-hands-bot
Copy link
Copy Markdown
Collaborator

[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

@VascoSch92
Copy link
Copy Markdown
Contributor Author

Hey
@jpelletier1 and @rbren What do you think? How should we continue?

Just let me know and I would do the relative changes

@all-hands-bot
Copy link
Copy Markdown
Collaborator

[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

1 similar comment
@all-hands-bot
Copy link
Copy Markdown
Collaborator

[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants