-
-
Notifications
You must be signed in to change notification settings - Fork 3
Adding non-administrative boundaries in vector tiles #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
| osm_id, | ||
| name, | ||
| type, | ||
| admin_level, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is currently there is 3346 non-admin objects, we haven't implemented filters like admin_level for these layers yet. For administrative boundaries, we filter by admin_level for zoom levels, Do you think it's necessary to apply some kind of zoom-level filtering for these non-administrative layers as well?
Possibly. Some boundary types always have admin_level=*, like boundary=indigenous_administration and boundary=religious_administration, so there’s no problem with reusing the filters. boundary=statistical also comes with admin_level=* much of the time. At low zoom levels, we can filter out boundaries with high administrative levels as well as the centroids of small boundaries.
Some boundary types don’t have anything like admin_level=*:
boundary=placecomes withplace=*. We can reuse the filter forplace=*on areas from other layers.boundary=timezoneshouldn’t have any filter, although the centroid could be filtered based on size. They tend to be large enough to show at low zoom levels.boundary=postal_codecan all be filtered out at the same time based on zoom level, since they’re inherently local features.
| end_decdate, | ||
| short_name, | ||
| official_name, | ||
| {{LENGUAGES}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should add any additional fields. A map of religious administration boundaries would probably want to filter by religion=* and denomination=*, while a map of time zone boundaries would probably want to style by utc=*. We could break out these relation types as separate layers, or if we combine them, then a more generic property could hold something that differentiates the features that share a single boundary type.
From OpenHistoricalMap/issues#1251
Non-administrative layers have been included in a separate provider named ohm_non_admin. We have also modified the boundary data fetching process. Previously, the imposm pipeline was designed to only store boundary=administrative in the database. We are now collecting all boundary=* tags and will use materialized views to filter between administrative and non-administrative data.
Since there is currently there is 3346 non-admin objects, we haven't implemented filters like admin_level for these layers yet. For administrative boundaries, we filter by admin_level for zoom levels, Do you think it's necessary to apply some kind of zoom-level filtering for these non-administrative layers as well?
currently deploy in staging https://vtiles.staging.openhistoricalmap.org/#1.57/13.5/27.1
cc. @1ec5