Skip to content

Remove duplicated rtl8188fu Config.in#2143

Open
conke wants to merge 7 commits into
OpenIPC:masterfrom
maxwit-openipc:remove-duplicated-rtl8188fu
Open

Remove duplicated rtl8188fu Config.in#2143
conke wants to merge 7 commits into
OpenIPC:masterfrom
maxwit-openipc:remove-duplicated-rtl8188fu

Conversation

@conke
Copy link
Copy Markdown

@conke conke commented May 27, 2026

There are 2 same lines for rtl8188fu in general/package/Config.in:

source "$BR2_EXTERNAL_GENERAL_PATH/package/rtl8188fu-openipc/Config.in"

conke added 7 commits May 27, 2026 02:47
Signed-off-by: Conke Hu <conke.hu@maxwit.com>
Fixes #1

Signed-off-by: Conke Hu <conke.hu@maxwit.com>
Signed-off-by: Conke Hu <conke.hu@maxwit.com>
Signed-off-by: Conke Hu <conke.hu@maxwit.com>
Signed-off-by: Conke Hu <conke.hu@maxwit.com>
There are 2 same lines for rtl8188fu in general/package/Config.in:
```
source "$BR2_EXTERNAL_GENERAL_PATH/package/rtl8188fu-openipc/Config.in"
```

Signed-off-by: Conke Hu <conke.hu@maxwit.com>
@widgetii
Copy link
Copy Markdown
Member

Thanks for the catch on the duplicate rtl8188fu line — that part of the change is clearly correct.

However, this PR's diff is much wider than the title/description suggests: 117 files, +231/-253, 7 commits. Looking at the commit list, only the last commit (remove duplicated rtl8188fu Config.in) matches what the description promises. The others appear to be unrelated downstream changes that came along because the branch was cut from a fork master that had drifted from upstream:

  • remap OPENIPC_KERNEL url to maxwit-openipc rewrites BR2_TOOLCHAIN_EXTERNAL_URL and BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION in 113 board defconfigs from github.com/openipc/{firmware,linux} to github.com/maxwit-openipc/{firmware,linux}. Upstream builds need to keep pointing at the OpenIPC org — the MaxWit mirror won't host every kernel/toolchain tag the upstream defconfigs reference, so this would break the matrix.
  • remove uboot.yml deletes the .github/workflows/uboot.yml CI workflow with no rationale given.
  • add /usr/share/openipc/customizer.sh introduces a new overlay script that hard-codes MaxWit-specific gpio labels (wled_pin, ircut_pin1, ircut_pin2) and a fw_printenv -n SN lookup. Nothing in the base init invokes it, so it would ship as dead code on every board.
  • add menuconfig support (the 4-line Makefile addition) is actually a nice standalone improvement and would be welcome on its own.

Could you split this into two PRs against a fresh branch cut from OpenIPC/firmware:master?

  1. The 1-line general/package/Config.in dedup (this PR's stated goal).
  2. The menuconfig Makefile target as its own PR.

Everything else (URL remap, uboot.yml removal, customizer.sh) looks like it belongs in the MaxWit downstream fork, not upstream. Easiest way is usually:

git fetch upstream
git checkout -b rtl8188fu-dedup upstream/master
# cherry-pick just the one commit, push, open new PR

Happy to re-review once it's narrowed down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants