hisilicon-osdrv-hi3516cv200: fix OV2735 .ini for MIPI (4 fields)#2155
Open
moontwister wants to merge 1 commit into
Open
hisilicon-osdrv-hi3516cv200: fix OV2735 .ini for MIPI (4 fields)#2155moontwister wants to merge 1 commit into
moontwister wants to merge 1 commit into
Conversation
Member
|
Good afternoon |
Four wrong fields in cv200's ov2735_i2c_1080p.ini that prevent it from working as MIPI on real hardware. Verified end-to-end against OpenIPC/majestic master+bcf6700 with its new SET_DEV_ATTR diagnostic log (see OpenIPC/majestic#278). [mode] input_mode = 4 → 0 (INPUT_MODE_MIPI = 0; 4 is unused) [mipi] data_type = 3 → 2 (OV2735 outputs RAW10, not RAW12) [mipi] lane_id = "0|1|2|3|..." → "0|1|-1|-1|..." (2-lane, not 4) [vi_dev] Input_mod = 2 → 5 (MIPI; 2 is VI_INPUT_MODE_DIGITAL_CAMERA, rejected by majestic's new MIPI mode check) Verified on TP-Link Kasa KC110 (Hi3518EV200 + OV2735 2-lane RAW10). With these four fields fixed, /proc/driver/hi_mipi shows the expected `LaneNum=2 RAW10 MIPI` (matches the vendor firmware diagnostic snapshot), ISP IRQs climb, VENC produces frames, RTSP delivers H.264 1080p with no LD_PRELOAD shim. cv300's already- correct ov2735_i2c_1080p.ini has the same MIPI fields (input_mode, data_type, lane_id) as this patch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
moontwister
force-pushed
the
cv200-ov2735-ini-input-mode
branch
from
dc51307 to
ff8e3a6
Compare
moontwister
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four wrong fields in cv200's
ov2735_i2c_1080p.inithat prevent it from working as MIPI on real hardware:[mode] input_mode40(INPUT_MODE_MIPI)INPUT_MODE_MIPI = 0;4is the unused successor ofLVDS=2/DC=3. Withinput_mode=4the ISP driver never configures the MIPI RX block.[mipi] data_type3(RAW_DATA_12BIT)2(RAW_DATA_10BIT)data_type=3, majestic faithfully sendsraw_data_type=3toHI_MIPI_SET_DEV_ATTRand/proc/driver/hi_mipiends up in RAW12 mode → garbled / no frames.[mipi] lane_id0|1|2|3|...(4-lane)0|1|-1|-1|...(2-lane)[vi_dev] Input_mod2(VI_INPUT_MODE_DIGITAL_CAMERA)5(MIPI)[vi_dev] Input_modand[mode] input_modemust agree. Master majestic (OpenIPC/majestic#278) now enforces this with a fail-fast:[mode] input_mode (0) and [vi_dev] Input_mod (2) disagree; expected Input_mod=5 for this input_mode.cv300's already-correct
ov2735_i2c_1080p.inihas the same MIPI fields (input_mode,data_type,lane_id) as this patch.Test plan — verified end-to-end
On a TP-Link Kasa KC110 (Hi3518EV200 + OV2735 2-lane MIPI RAW10) against
majestic master+bcf6700(which adds theSET_DEV_ATTR: …diagnostic log):.inistate[mode] input_mode (4)doesn't even reach majestic — load_hisilicon never enters the MIPI case.input_mode=0, others still wrongInput_mod (2) disagree; expected 5Input_mod=5SET_DEV_ATTR: input_mode=0 raw_data_type=3 lanes=[0,-1,-1,-1],/proc/driver/hi_mipi→LaneNum=1 RAW12 MIPI. Pipeline up but wrong RAW depth & lane count.data_type=2+lane_id="0|1|-1|..."(this PR)SET_DEV_ATTR: input_mode=0 raw_data_type=2 lanes=[0,1,-1,-1],/proc/driver/hi_mipi→LaneNum=2 RAW10 MIPI(matches vendor diagnostic snapshot). ISP IRQs climb, VENC produces frames, RTSP delivers H.264 1080p — no LD_PRELOAD shim required.Context
Companion to #2154 (cv200
load_hisiliconOV2735 case). Originally split out from closed #2151 (KC110 board package, re-filed as OpenIPC/builder#99). Replaces my earlier shim-package #2152 entirely once this lands and majestic master is released — see OpenIPC/majestic#278 for the full diagnostic trail.🤖 Generated with Claude Code