Add FREENECT_DEPTH_REGISTERED support to fakenect #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rib
reviewed
Jan 11, 2018
fakenect/fakenect.c
Outdated
| int freenect_get_depth_mode_count() | ||
| { | ||
| return 1; | ||
| return 2; |
Contributor
There was a problem hiding this comment.
I think there's a (pre-existing) off-by-one error with the count here (my fault when enabling the _DEPTH_MM format) so this should be bumped to 3
Cwiiis
force-pushed
the
fakenect-depth-registration
branch
from
987232d to
035bc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of depth mode FREENECT_DEPTH_REGISTERED with fakenect.