Skip to content

More RDM Responder tests#1999

Merged
peternewman merged 19 commits intoOpenLightingProject:masterfrom
peternewman:plugfest
Apr 4, 2026
Merged

More RDM Responder tests#1999
peternewman merged 19 commits intoOpenLightingProject:masterfrom
peternewman:plugfest

Conversation

@peternewman
Copy link
Copy Markdown
Member

No description provided.

@peternewman peternewman added this to the 0.11.0 milestone Mar 11, 2025
@peternewman peternewman requested a review from kripton March 11, 2025 00:55
Copy link
Copy Markdown
Contributor

@aroffringa aroffringa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me although I struggle with the context of the code. You're introducing a few 'const string' parameter which I suspect would be better to be reference types; I've marked those.

Comment thread common/rdm/ResponderHelper.cpp Outdated
Comment thread common/rdm/ResponderHelper.cpp Outdated
Comment thread common/rdm/ResponderHelper.cpp Outdated
Comment thread include/ola/rdm/ResponderHelper.h Outdated
Comment thread include/ola/rdm/ResponderHelper.h Outdated
Comment thread include/ola/rdm/ResponderHelper.h Outdated
Comment thread include/ola/rdm/ResponderHelper.h Outdated
Comment thread include/ola/rdm/ResponderNSCStatus.h
@peternewman
Copy link
Copy Markdown
Member Author

Looks ok to me although I struggle with the context of the code.

The C++ (or both languages), which bit or bits (or all of it) and I can try and give a bit more background.

You're introducing a few 'const string' parameter which I suspect would be better to be reference types; I've marked those.

Sorry I realised I should have taken your suggestions directly, although we've typically styled them slightly differently.

@aroffringa
Copy link
Copy Markdown
Contributor

Looks ok to me although I struggle with the context of the code.

The C++ (or both languages), which bit or bits (or all of it) and I can try and give a bit more background.

I'm not familiar with all parts of the code (yet :D). I'll try to slowly read up more what's happening where. For now I think it's all good -- I think it's fine to merge.

@peternewman peternewman merged commit ec76778 into OpenLightingProject:master Apr 4, 2026
7 of 22 checks passed
@peternewman
Copy link
Copy Markdown
Member Author

I'm not familiar with all parts of the code (yet :D). I'll try to slowly read up more what's happening where. For now I think it's all good -- I think it's fine to merge.

So very broadly (and apologies for any egg sucking) this PR is all about implementing more RDM (E1.20) commands. It's an in-band communications method on the existing DMX bus, allowing you to set start address for example (and much more). We implement a set of "conformance" tests, to try and see how well people are complying with the standards/spot errors in implementations (the Python code) and a set of dummy/fake responders for us (and others) to use to test their implementations (and our RDM tests) (the C++ code in this PR).

This specific PR is adding some new PIDs (commands) that are part of E1.37-5 to our dummy responders (with common code to do the middle heavy lifting in ResponderHelper) and then tests in tools/rdm to test ours (and others) implementations of those (from an RDM perspective, rather than as a unit test).

The standards are available to download from https://tsp.esta.org/tsp/documents/published_docs.php

peternewman added a commit that referenced this pull request Apr 18, 2026
Revert some stuff via 146cf26 which accidentally snuck into #1999 by mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants