feat(fs): support get fileobj by path#1055
Draft
hshpy wants to merge 3 commits intoOpenListTeam:mainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for getting file or directory information by path in the AliyunDrive Open driver. The main changes involve replacing a custom interface with the standard Getter interface pattern used throughout the codebase.
- Removes the
GetObjInfointerface and replaces it with the standardGetmethod implementation - Implements the
Getmethod in the AliyunDrive Open driver to retrieve files by path using the/adrive/v1.0/openFile/get_by_pathAPI endpoint - Simplifies the
Linkfunction by removing caching logic and using the standardized approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/driver/driver.go | Removes the custom GetObjInfo interface definition |
| internal/op/fs.go | Simplifies Link function by removing cache logic and using GetUnwrap directly |
| drivers/aliyundrive_open/driver.go | Implements the Get method to retrieve files by path via API call |
| drivers/115_open/driver.go | Renames GetObjInfo method to Get to match standard interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7cea825 to
3b2c3f3
Compare
46770f7 to
8a3991e
Compare
7 tasks
Contributor
Author
是有这个问题,只改了阿里的,没115账号。 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
给阿里云盘open添加通过路径获取文件或目录信息,加快爆米花,emby等APP的起播速度。
fileobj获取顺序是Get实现路径获取,List向上级缓存查找,再向网盘获取。
以前只有非网盘驱动实现,忽略缓存影响不大,但目前有115open,阿里云盘open也实现,所以提前listcache查找。