feat(preview): support Browser built-in PDF Preview#1352
Draft
feat(preview): support Browser built-in PDF Preview#1352
Conversation
Member
我没找到好的办法既能兼容之前点击就带文件名下载,也兼容必须Inline的内置PDF预览功能。 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: ShenLin <773933146@qq.com>
fc2e89c to
749fc07
Compare
Member
|
@xrgzs 我很长时间都没时间搞,我认为其实可以完全无视302,仅支持代理。带有限制性的功能没觉得有什么问题。这东西主要难点仅仅是我们给文件名都默认加上了。我不想复制一套Proxy逻辑加个路由专门给preview用,就只加了参数。如果302的时候会导致?需要变成&,我们没有nginx类似的$is_arg参数,也需要另外处理。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description / 描述
兼容浏览器内置PDF预览,一个是因为本来就应该支持,一个是因为Chromium增加了画笔工具,更好用了。
未对OpenList进行测试,本地html调用pdf以及直接Nginx下测试均无问题。
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。