Skip to content

Fix out-of-bounds accesses in the LAPACK LIN tests (Reference-LAPACK PR 1179) #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 1 commit into from
Jan 11, 2026
+35 −35
Merged

Fix out-of-bounds accesses in the LAPACK LIN tests (Reference-LAPACK PR 1179) #5600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions lapack-netlib/TESTING/LIN/cerrtsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ SUBROUTINE CERRTSQR( PATH, NUNIT )
INTEGER I, INFO, J, MB, NB
* ..
* .. Local Arrays ..
COMPLEX A( NMAX, NMAX ), T( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU(NMAX)
COMPLEX A( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU( 5 )
* ..
* .. External Subroutines ..
EXTERNAL ALAESM, CHKXER, CGEQR,
Expand Down Expand Up @@ -103,7 +103,6 @@ SUBROUTINE CERRTSQR( PATH, NUNIT )
DO I = 1, NMAX
A( I, J ) = 1.E0 / CMPLX( REAL( I+J ), 0.E0 )
C( I, J ) = 1.E0 / CMPLX( REAL( I+J ), 0.E0 )
T( I, J ) = 1.E0 / CMPLX( REAL( I+J ), 0.E0 )
END DO
W( J ) = 0.E0
END DO
Expand Down Expand Up @@ -161,8 +160,9 @@ SUBROUTINE CERRTSQR( PATH, NUNIT )
*
* CGEMQR
*
TAU(1)=1
TAU(2)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'CGEMQR'
NB=1
INFOT = 1
Expand Down Expand Up @@ -251,8 +251,9 @@ SUBROUTINE CERRTSQR( PATH, NUNIT )
*
* CGEMLQ
*
TAU(1)=1
TAU(2)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'CGEMLQ'
NB=1
INFOT = 1
Expand Down
17 changes: 8 additions & 9 deletions lapack-netlib/TESTING/LIN/derrtsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ SUBROUTINE DERRTSQR( PATH, NUNIT )
INTEGER I, INFO, J, MB, NB
* ..
* .. Local Arrays ..
DOUBLE PRECISION A( NMAX, NMAX ), T( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU(NMAX*2)
DOUBLE PRECISION A( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU( 5 )
* ..
* .. External Subroutines ..
EXTERNAL ALAESM, CHKXER, DGEQR,
Expand Down Expand Up @@ -103,7 +103,6 @@ SUBROUTINE DERRTSQR( PATH, NUNIT )
DO I = 1, NMAX
A( I, J ) = 1.D0 / DBLE( I+J )
C( I, J ) = 1.D0 / DBLE( I+J )
T( I, J ) = 1.D0 / DBLE( I+J )
END DO
W( J ) = 0.D0
END DO
Expand Down Expand Up @@ -161,10 +160,9 @@ SUBROUTINE DERRTSQR( PATH, NUNIT )
*
* DGEMQR
*
TAU(1)=1
TAU(2)=1
TAU(3)=1
TAU(4)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'DGEMQR'
NB=1
INFOT = 1
Expand Down Expand Up @@ -253,8 +251,9 @@ SUBROUTINE DERRTSQR( PATH, NUNIT )
*
* DGEMLQ
*
TAU(1)=1
TAU(2)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'DGEMLQ'
NB=1
INFOT = 1
Expand Down
23 changes: 11 additions & 12 deletions lapack-netlib/TESTING/LIN/serrtsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ SUBROUTINE SERRTSQR( PATH, NUNIT )
INTEGER I, INFO, J, MB, NB
* ..
* .. Local Arrays ..
REAL A( NMAX, NMAX ), T( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU(NMAX*2)
REAL A( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU( 5 )
* ..
* .. External Subroutines ..
EXTERNAL ALAESM, CHKXER, SGEQR,
Expand All @@ -101,11 +101,10 @@ SUBROUTINE SERRTSQR( PATH, NUNIT )
*
DO J = 1, NMAX
DO I = 1, NMAX
A( I, J ) = 1.D0 / REAL( I+J )
C( I, J ) = 1.D0 / REAL( I+J )
T( I, J ) = 1.D0 / REAL( I+J )
A( I, J ) = 1. / REAL( I+J )
C( I, J ) = 1. / REAL( I+J )
END DO
W( J ) = 0.D0
W( J ) = 0.
END DO
OK = .TRUE.
*
Expand Down Expand Up @@ -161,10 +160,9 @@ SUBROUTINE SERRTSQR( PATH, NUNIT )
*
* SGEMQR
*
TAU(1)=1
TAU(2)=1
TAU(3)=1
TAU(4)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'SGEMQR'
NB=1
INFOT = 1
Expand Down Expand Up @@ -253,8 +251,9 @@ SUBROUTINE SERRTSQR( PATH, NUNIT )
*
* SGEMLQ
*
TAU(1)=1
TAU(2)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'SGEMLQ'
NB=1
INFOT = 1
Expand Down
15 changes: 8 additions & 7 deletions lapack-netlib/TESTING/LIN/zerrtsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ SUBROUTINE ZERRTSQR( PATH, NUNIT )
INTEGER I, INFO, J, MB, NB
* ..
* .. Local Arrays ..
COMPLEX*16 A( NMAX, NMAX ), T( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU(NMAX)
COMPLEX*16 A( NMAX, NMAX ), W( NMAX ),
$ C( NMAX, NMAX ), TAU( 5 )
* ..
* .. External Subroutines ..
EXTERNAL ALAESM, CHKXER, ZGEQR,
Expand Down Expand Up @@ -103,7 +103,6 @@ SUBROUTINE ZERRTSQR( PATH, NUNIT )
DO I = 1, NMAX
A( I, J ) = 1.D0 / DBLE( I+J )
C( I, J ) = 1.D0 / DBLE( I+J )
T( I, J ) = 1.D0 / DBLE( I+J )
END DO
W( J ) = 0.D0
END DO
Expand Down Expand Up @@ -161,8 +160,9 @@ SUBROUTINE ZERRTSQR( PATH, NUNIT )
*
* ZGEMQR
*
TAU(1)=1
TAU(2)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'ZGEMQR'
NB=1
INFOT = 1
Expand Down Expand Up @@ -251,8 +251,9 @@ SUBROUTINE ZERRTSQR( PATH, NUNIT )
*
* ZGEMLQ
*
TAU(1)=1
TAU(2)=1
DO I = 1, 5
TAU( I ) = 1
END DO
SRNAMT = 'ZGEMLQ'
NB=1
INFOT = 1
Expand Down
Loading