fix: Correct inverted required field logic in schema generator#1711
Merged
openminddev merged 4 commits intoOpenMind:mainfrom Feb 15, 2026
Merged
fix: Correct inverted required field logic in schema generator#1711openminddev merged 4 commits intoOpenMind:mainfrom
openminddev merged 4 commits intoOpenMind:mainfrom
Conversation
This was referenced Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Wanbogang
approved these changes
Jan 27, 2026
Contributor
Wanbogang
left a comment
There was a problem hiding this comment.
Bug confirmed: Inverted logic in required field detection.
Fix verified:
- Before:
required = has_default(fields with defaults marked required) - After:
required = not has_default(correct logic)
Logic validated:
- Field without default → required = True
- Field with default → required = False
Wanbogang
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1610
Problem:
Solution:
required: has_defaulttorequired: not has_defaultImpact: