fix: replace manual ABI decoding with web3.py in GovernanceEthereum#2069
Closed
Wanbogang wants to merge 10 commits intoOpenMind:mainfrom
Closed
fix: replace manual ABI decoding with web3.py in GovernanceEthereum#2069Wanbogang wants to merge 10 commits intoOpenMind:mainfrom
Wanbogang wants to merge 10 commits intoOpenMind:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Please don't change the test file name |
Contributor
Author
noted |
- Replace manual ABI decoding with web3.py library - Add minimal ABI definition for getRuleSet function - Update tests to mock web3.py interactions - Improve error handling for blockchain calls Fixes OpenMind#1824
96b73fe to
0bc2d98
Compare
Contributor
Author
|
Hi @openminddev tests/inputs/ I have a question regarding the test structure for Current situation:
Both test files import and test the same My questions:
Current PR status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the fragility and testability issues identified in issue #1824.
Problem
The previous implementation used manual hex parsing in
decode_eth_responsewhich was:Solution
Replaced manual ABI decoding with web3.py contract calls:
decode_eth_responsefunction with manual hex parsingweb3.pycontract.functions.getRuleSet().call()for robust ABI decodinggetRuleSetfunctionBadFunctionCallOutputandContractLogicErrorImproved test coverage:
web3.pyinteractions properly