Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the W&B metrics taxonomy RFC in ART so run metrics land in stable top-level namespaces that are easier to panel and compare in W&B.
The main behavior change is hierarchical cost logging. Users can log leaf metrics like
costs/train/llm_judge/correctnessorcosts/train/tinker_train, and ART will automatically emit parent rollups likecosts/trainandcosts/all, plus cumulativecosts/cum/*metrics across steps.This PR also adds a
MetricsBuilderAPI and a@track_api_cost(...)decorator so judge / external API spend can be logged into the same taxonomy with model-aware pricing.What changed
reward/*,loss/*,throughput/*,costs/*,time/*,data/*,train/*,val/*, andtest/*.MetricsBuilderfor user-owned metrics, hierarchical cost rollups,costs/cum/*, cumulativetime/*anddata/*, derived throughput metrics, exactdata/cum/num_unique_scenarios, and persisted resume state.time/step_wall_s,time/step_trainer_s,time/step_actor_s,time/step_eval_s,data/step_*,train/*, and automatic localcosts/gpuwhen pricing is known.@track_api_cost(...)for OpenAI/Anthropic responses with explicitproviderandmodel_name, cache-aware pricing, and hooks for custom extractors / registered pricing.costs_*keys in favor of hierarchicalcosts/...paths.Notes
track_api_cost(...)requires explicitproviderandmodel_nameand raises if pricing is missingtraining_stepas the x-axis;