Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mab879
force-pushed
the
fix_autotail_json_bugs
branch
from
a1a18c2 to
30b68d2
Compare
jan-cerny
reviewed
Mar 30, 2026
| if not profile_dict.get("base_profile_id") and not profile_dict.get("id"): | ||
| raise ValueError("You must define a base_profile_id or an id") | ||
| self.extends = profile_dict.get("base_profile_id") | ||
| self.profile_id = profile_dict.get("id") |
Member
There was a problem hiding this comment.
Can the self.profile_id be None after this assignment?
Member
Author
There was a problem hiding this comment.
No, there is a None check at 289.
Member
Author
There was a problem hiding this comment.
On second look, it could, but this handled in get the getter for profile_id.
Mab879
force-pushed
the
fix_autotail_json_bugs
branch
2 times, most recently
from
f0251c9 to
d559dbb
Compare
jan-cerny
requested changes
Mar 31, 2026
Comment on lines
+105
to
+108
| with open(file_path) as fp: | ||
| profile_dict = json.load(fp) | ||
| with pytest.raises(ValueError): | ||
| p.import_json_tailoring_profile(profile_dict) |
Member
There was a problem hiding this comment.
It looks like the test accidentally passes, but there is a problem that the JSON isn't the profile object, it's a dictionary where the profiles key contains a list of profile objects.
Suggested change
| with open(file_path) as fp: | |
| profile_dict = json.load(fp) | |
| with pytest.raises(ValueError): | |
| p.import_json_tailoring_profile(profile_dict) | |
| with open(file_path) as fp: | |
| json_data = json.load(fp) | |
| profile_dict = json_data["profiles"][0] | |
| with pytest.raises(ValueError) as e: | |
| p.import_json_tailoring_profile(profile_dict) | |
| assert str(e.value) == "You must define a base_profile_id or an id" |
Add tests for the changes
Mab879
force-pushed
the
fix_autotail_json_bugs
branch
from
d559dbb to
7190c00
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.