Make forms accessible by making them work without JavaScript#557
Closed
Make forms accessible by making them work without JavaScript#557
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Thanks for bringing this to my attention. I'll put this in the backlog for now, to revisit at a later point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR for now only contains the /apply/grant refactoring; after verifying that it works well, we can proceed with migrating the other forms.
Note: currently the (untouched) LTS form is rendered without JavaScript because the page doesn't use dynamic import with
ssr: false, but if you try to actually submit the LTS form without JavaScript, it won't work because there are several problems.@dergigi can you share a staging env so I can test the submission part?
Alternatively you can test it yourself and let me know, thanks.