Skip to content

Adjust timer/messages in projector-detail#5709

Closed
Elblinator wants to merge 14 commits intoOpenSlides:mainfrom
Elblinator:5225-timer-messgaes-change
Closed

Adjust timer/messages in projector-detail#5709
Elblinator wants to merge 14 commits intoOpenSlides:mainfrom
Elblinator:5225-timer-messgaes-change

Conversation

@Elblinator
Copy link
Copy Markdown
Member

@Elblinator Elblinator commented Jan 5, 2026

context #5225

for live look at client5225-referenz

@Elblinator Elblinator added this to the 4.3 milestone Jan 5, 2026
@Elblinator Elblinator self-assigned this Jan 5, 2026
@Elblinator Elblinator added the enhancement General enhancement which is neither bug nor feature label Jan 5, 2026
@Elblinator Elblinator marked this pull request as ready for review January 7, 2026 15:55
Copy link
Copy Markdown
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but I have some questions

@Elblinator Elblinator force-pushed the 5225-timer-messgaes-change branch from 3ac69e2 to 54bd246 Compare January 12, 2026 13:27
@Elblinator Elblinator added the waiting Waiting for some other PR/feature; more details in comments label Jan 12, 2026
@Elblinator
Copy link
Copy Markdown
Member Author

waiting until projector merge is done

@Elblinator
Copy link
Copy Markdown
Member Author

Elblinator commented Jan 12, 2026

Task:

  • look at subscriptions
  • fix missing referencce projector for messages

@Elblinator
Copy link
Copy Markdown
Member Author

Given that there are two undeletable messages which are only projectable directly at the projector( you are currently at), I decided to align the other messaged behaviour to this behaviour

@Elblinator Elblinator removed the waiting Waiting for some other PR/feature; more details in comments label Jan 30, 2026
@Elblinator Elblinator assigned luisa-beerboom and MSoeb and unassigned Elblinator Jan 30, 2026
@Elblinator Elblinator requested review from MSoeb and luisa-beerboom and removed request for bspekker January 30, 2026 10:48
@luisa-beerboom luisa-beerboom removed their assignment Feb 2, 2026
@MSoeb
Copy link
Copy Markdown

MSoeb commented Feb 4, 2026

Me and @emanuelschuetze talked about the changes and made the decision to skip it for now, because a few more changes and some kind of rethinking about functionality are needed here.

Therefor the PR will be closed.

@MSoeb MSoeb closed this Feb 4, 2026
@Elblinator Elblinator deleted the 5225-timer-messgaes-change branch February 6, 2026 12:11
@Elblinator Elblinator restored the 5225-timer-messgaes-change branch February 6, 2026 12:12
@Elblinator Elblinator reopened this Feb 6, 2026
@Elblinator Elblinator closed this Feb 6, 2026
@Elblinator Elblinator reopened this Feb 6, 2026
@Elblinator Elblinator closed this Feb 6, 2026
@Elblinator Elblinator deleted the 5225-timer-messgaes-change branch March 26, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature staging-t1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants