Skip to content

Optimize get_revision.sh #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Mar 22, 2026
Merged

Optimize get_revision.sh #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Scripts/CI/ag_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ clone_checkout_ag() {
git stash --quiet || true
git reset --hard --quiet origin/main
fi
git checkout --quiet $revision
if [ -n "$revision" ]; then
git checkout --quiet "$revision"
else
echo "No pinned revision for DarwinPrivateFrameworks, using default branch."
fi
}

update_ag() {
Expand Down
4 changes: 2 additions & 2 deletions Scripts/CI/get_revision.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ PACKAGE_RESOLVED_PATH="Package.resolved"

# Check if the Package.resolved file exists
if [[ ! -f "$PACKAGE_RESOLVED_PATH" ]]; then
echo "Error: $PACKAGE_RESOLVED_PATH file not found!"
echo "Error: $PACKAGE_RESOLVED_PATH file not found!" >&2
exit 1
fi

Expand All @@ -36,7 +36,7 @@ REVISION=$(jq -r --arg name "$DEPENDENCY_NAME" '

# Check if a revision was found
if [[ -z "$REVISION" ]]; then
echo "No revision found for dependency: $DEPENDENCY_NAME"
echo "No revision found for dependency: $DEPENDENCY_NAME" >&2
exit 1
else
echo "$REVISION"
Expand Down
Loading