Merged
Conversation
…irect artifact upload - Generate `.binaryTarget(name:path:)` entries instead of URL-based ones for non-tag (manual) builds since no release tag is available - Replace upload-artifact@v4 with v7 using `archive: false` to upload a single xcframeworks.zip directly, avoiding the zip-of-zips issue when downloading
Kyle-Ye
changed the title
🤖 Augment PR SummarySummary: Adjusts the XCFramework build action to emit local-path 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Only create individual xcframework zips when building for a release tag, since non-tag builds don't need them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 26.85% 26.85% -0.01%
==========================================
Files 671 671
Lines 43470 43470
==========================================
- Hits 11676 11675 -1
- Misses 31794 31795 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use `zip -ry` instead of `zip -r` to preserve macOS framework bundle symlinks (Versions/Current, top-level Modules/Resources). Without this, codesigning fails because the framework structure is invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.