Skip to content

INTENT-4 §11: session-scoped intent registration#45

Draft
JarbasAl wants to merge 2 commits into
devfrom
spec/intent4-session-scoped
Draft

INTENT-4 §11: session-scoped intent registration#45
JarbasAl wants to merge 2 commits into
devfrom
spec/intent4-session-scoped

Conversation

@JarbasAl
Copy link
Copy Markdown
Member

@JarbasAl JarbasAl commented May 28, 2026

Companion issue: #47

Summary

Every intent registration is automatically keyed by session_id from context.session.session_id — no wire-shape change needed. "default" is the global/inherited scope; all sessions inherit it. Session-scoped registrations extend the pool; the existing blacklist fields are the sole narrowing mechanism.

Effective pool for session X: default intents ∪ session-X intents − blacklisted entries

Dispatch of session-scoped intents routes back through the bridge transparently via existing MSG-1 destination-based routing (BRIDGE-1 §3.2).

Changes

  • §1 scope — add session-scoped registration to defined list
  • §8.1 — replacement key is now quintuple (session_id, skill_id, intent_name, lang, method); session_id read from context.session.session_id, never from message.data
  • §8.4ovos.skill.deregister gains optional session_id field for bulk satellite cleanup on disconnect
  • §10.1ovos.intent.list gains optional session_id filter returning the effective pool (default ∪ session-specific); response entries include session_id
  • §11 (new) — full model: indexing, inheritance rule, deregistration/teardown, plugin visibility, dispatch routing
  • §12 conformance (renumbered from §11) — orchestrator MUST key manifest by quintuple; serve session-aware list queries

Companion

BRIDGE-1 §4.4 (PR #43) documents the satellite skill registration pattern this spec enables.

Every registration is automatically keyed by the session_id from the
registration message context — no shape change needed. The effective
intent pool for session X = default intents ∪ session-X intents −
blacklisted. "default" is the global/inherited scope; all sessions
inherit it. Session-scoped registrations extend, never narrow; the
blacklist is the sole narrowing mechanism.

Changes:
- §1 scope: add session-scoped registration to the defined list
- §8.1: replacement key is now quintuple (session_id, skill_id,
  intent_name, lang, method)
- §8.4: ovos.skill.deregister gains optional session_id field for
  satellite bulk-cleanup on disconnect
- §10.1: ovos.intent.list gains optional session_id filter; when
  provided returns effective pool (default ∪ session-specific);
  each response entry now includes session_id
- §11 (new): session-scoped registration — indexing model,
  inheritance rule, deregistration/teardown, plugin visibility,
  dispatch routing (transparent via existing MSG-1 destination)
- §12 conformance (renumbered from §11): orchestrator MUST now
  key manifest by quintuple and serve session-aware list queries

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Warning

Review limit reached

@JarbasAl, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8578aea9-0a26-441d-b36d-cfe0d0fa0d95

📥 Commits

Reviewing files that changed from the base of the PR and between cec6c7d and 3e75b10.

📒 Files selected for processing (1)
  • ovos-intent-4.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/intent4-session-scoped

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

session_id must come from Message.context["session"]["session_id"],
not from Message.data. Reading from data would let a producer
register intents under an arbitrary session it does not own;
context is set by the session the producer is running under and
cannot be forged by payload content.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant