fix(gcpt-collection): fix the bug that only process the first regex#63
Open
Frankslu wants to merge 1 commit intoOpenXiangShan:mainfrom
Open
fix(gcpt-collection): fix the bug that only process the first regex#63Frankslu wants to merge 1 commit intoOpenXiangShan:mainfrom
Frankslu wants to merge 1 commit intoOpenXiangShan:mainfrom
Conversation
Frankslu
changed the title
Frankslu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous calculation_base.py will iterate file and regex list to process all calculator with regex. However, when reach the second loop in
for pm in self.parse_map, the file pointer won't move to head infor line in file. So it can only process the first calculator with regex. In this version we moved the iteration of the calculator to the iteration of the file, which can correctly process all calculator.