enhancement: optimized reorg handling by deferring checks to end of stream (historic) #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #227
Description
This PR optimizes the historic/sync scanning modes by deferring reorg checks until after all block ranges have been streamed.
Changes
stream_historical_rangein common.rs:BlockNotFound), sendReorgDetectednotification and re-stream all non-finalized blockshandle_historicalin block_range_scanner.rs:ReorgHandlerinstantiation and parameter passing (no longer needed for historic mode)catchup_historical_blocksno longer requiresreorg_handlerparameter