Make mongo and redis optional dependencies#238
Open
zamiang wants to merge 2 commits intoOptimalBits:masterfrom
Open
Make mongo and redis optional dependencies#238zamiang wants to merge 2 commits intoOptimalBits:masterfrom
zamiang wants to merge 2 commits intoOptimalBits:masterfrom
Conversation
|
Good suggestion! Mongo & Redis are not required when we use 3-d party driver like Knex-based or Sequelize-based (or even we are just developing with in-memory database). update: shouldn't we need mention proper install steps in readme? |
zamiang
force-pushed
the
optional-redis-mongo
branch
from
23acf6f to
51ea487
Compare
Author
|
@deksden also a good suggestion! Added a note about installing redis and mongo to the install step of the readme |
Author
|
@manast any word on this? I believe this is a low risk, simple change but let me know if I can improve it in any dimension. |
Author
|
@manast any update here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #221