Skip to content

Potential fix for 1 code quality finding #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TKorr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for 1 code quality finding #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ds/slot_arena.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@
//!
//! ## Implementation Notes
//!
//! - `SlotId` carries a generation counter; stale handles return `None`
//! - `SlotId` stores the generation value assigned by the arena; the arena
//! maintains the authoritative generation counter and validates `SlotId`s
//! against it so that stale handles return `None`
//! - Physical slot indices may be reused after removal, but the
//! generation counter prevents ABA hazards
//! - `len()` tracks live entries, not `slots.len()`
Expand Down