fix(unused-variables): treat get_defined_vars() as using all variables in scope#158
Open
calebdw wants to merge 1 commit into
Open
fix(unused-variables): treat get_defined_vars() as using all variables in scope#158calebdw wants to merge 1 commit into
calebdw wants to merge 1 commit into
Conversation
calebdw
force-pushed
the
calebdw/push-uoqowqsutxol
branch
from
7385c1a to
f5d93af
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…s in scope `get_defined_vars()` (like `compact()`) references variables by name without a direct read. When present in a function/method body, suppress unused-variable diagnostics for all locals to avoid false positives on debug/introspection code.
calebdw
force-pushed
the
calebdw/push-uoqowqsutxol
branch
from
f5d93af to
b894669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_defined_vars()(likecompact()) references variables by name without a direct read. When present in a function/method body, suppress unused-variable diagnostics for all locals to avoid false positives on debug/introspection code.