-
Notifications
You must be signed in to change notification settings - Fork 737
⚡ Bolt: Optimize RequestMetrics & SpeculateMetrics Serialization #7119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ZeyuChen
wants to merge
1
commit into
develop
from
bolt/optimize-metrics-serialization-10751143528886952738
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
|
|
||
| ## 2025-02-23 - Avoid dataclasses.asdict in Hot Paths | ||
| **Learning:** `dataclasses.asdict` does recursive deepcopy internally and is incredibly slow for large dataclasses or objects instantiated frequently. In FastDeploy, it was used in `RequestMetrics.to_dict()`, creating significant overhead. | ||
| **Action:** When defining `to_dict()` or custom serialization methods for fast/frequent dataclasses, avoid `asdict`. Instead, iterate through `self.__dataclass_fields__` with `getattr` and do shallow copying for basic types (`int`, `float`, `str`, `bool`, `type(None)`). For nested dataclasses, ensure they also implement their own `to_dict()` method to skip the `asdict` recursive penalty. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -897,7 +897,26 @@ def to_dict(self): | |
| """ | ||
| Convert the RequestMetrics object to a dictionary. | ||
| """ | ||
| return {k: v for k, v in asdict(self).items()} | ||
| import dataclasses | ||
|
|
||
| res = {} | ||
| for k in self.__dataclass_fields__: | ||
| v = getattr(self, k) | ||
|
Comment on lines
+900
to
+904
|
||
| if type(v) in (int, float, str, bool, type(None)): | ||
| res[k] = v | ||
| elif isinstance(v, list): | ||
| res[k] = list(v) | ||
| elif isinstance(v, dict): | ||
| res[k] = dict(v) | ||
| else: | ||
| if dataclasses.is_dataclass(v): | ||
| if hasattr(v, "to_dict"): | ||
| res[k] = v.to_dict() | ||
| else: | ||
| res[k] = dataclasses.asdict(v) | ||
| else: | ||
| res[k] = v | ||
| return res | ||
|
|
||
| def record_recv_first_token(self): | ||
| cur_time = time.time() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 标题需要至少包含一个标签(模板要求形如
[Optimization] ...)。当前标题包含引号/emoji 且缺少方括号标签,建议改为例如[Optimization] Optimize RequestMetrics & SpeculateMetrics Serialization(或选择更贴切的标签)。