Skip to content

update fleet_ops#7859

Open
liuruyan wants to merge 1 commit into
PaddlePaddle:developfrom
liuruyan:dev_fleet
Open

update fleet_ops#7859
liuruyan wants to merge 1 commit into
PaddlePaddle:developfrom
liuruyan:dev_fleet

Conversation

@liuruyan
Copy link
Copy Markdown
Contributor

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented May 19, 2026

Thanks for your contribution!

Copy link
Copy Markdown

@PaddlePaddle-bot PaddlePaddle-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Paddle-CI-Agent | pr_review | 2026-05-19 20:30:35

📋 Review 摘要

PR 概述:将 MoE EP 及 FP8 量化模块中 PaddleFleet 算子的导入路径从 paddlefleet.ops 更新为 paddlefleet_ops,适配上游包重命名。
变更范围fastdeploy/model_executor/layers/moe/ep.pyfastdeploy/model_executor/layers/quantization/fp8_utils.py
影响面 Tag[OP] [Quantization]

问题

未发现阻塞性问题。

📝 PR 规范检查

PR 标题缺少官方 Tag,且描述各 section 均为空/占位符,需补充完整内容。

标题建议(可直接复制):

  • [BugFix] Update PaddleFleet ops import path from paddlefleet.ops to paddlefleet_ops

PR 描述建议(可直接复制,必须复刻 checklist §D2 模板的完整结构):

## Motivation
适配上游 PaddleFleet 包重命名:将 `paddlefleet.ops.deep_ep``paddlefleet.ops.deep_gemm` 的导入路径分别更新为 `paddlefleet_ops.deep_ep``paddlefleet_ops.deep_gemm`## Modifications
- `fastdeploy/model_executor/layers/moe/ep.py`:更新 deep_ep 导入路径(`paddlefleet.ops.deep_ep``paddlefleet_ops.deep_ep`- `fastdeploy/model_executor/layers/quantization/fp8_utils.py`:更新 deep_gemm 导入路径(`paddlefleet.ops.deep_gemm``paddlefleet_ops.deep_gemm`## Usage or Command
N/A

## Accuracy Tests
N/A

## Checklist

- [ ] Add at least a tag in the PR title.
  - Tag list: [`[FDConfig]`,`[APIServer]`,`[Engine]`, `[Scheduler]`, `[PD Disaggregation]`, `[Executor]`, `[Graph Optimization]`, `[Speculative Decoding]`, `[RL]`, `[Models]`, `[Quantization]`, `[Loader]`, `[OP]`, `[KVCache]`, `[DataProcessor]`, `[BugFix]`, `[Docs]`, `[CI]`, `[Optimization]`, `[Feature]`, `[Benchmark]`, `[Others]`, `[XPU]`, `[HPU]`, `[GCU]`, `[DCU]`, `[Iluvatar]`, `[Metax]`]
  - You can add new tags based on the PR content, but the semantics must be clear.
- [ ] Format your code, run `pre-commit` before commit.
- [ ] Add unit tests. Please write the reason in this PR if no unit tests.
- [ ] Provide accuracy results.
- [ ] If the current PR is submitting to the `release` branch, make sure the PR has been submitted to the `develop` branch, then cherry-pick it to the `release` branch with the `[Cherry-Pick]` PR tag.

总体评价

变更逻辑清晰,属于上游包路径适配,代码改动正确一致。建议补充 PR 标题 Tag 及描述信息后合入。

@PaddlePaddle-bot
Copy link
Copy Markdown

PaddlePaddle-bot commented May 19, 2026

🤖 Paddle-CI-Agent | ci_status_monitor | 2026-05-19 23:44:59

CI报告基于以下代码生成(30分钟更新一次):


1 任务总览

存在 1 个 Required 失败任务,需优先处理后方可合并。

总执行(rerun次数) 总任务 ✅ 通过 ❌ 失败 ⏳ 运行中 ⏸️ 等待中 跳过
41(0) 41 38 2 0 1 0

2 任务状态汇总

2.1 Required任务:9/10 通过

必选任务阻塞合并,失败需优先处理。

状态 任务 耗时 根因 修复建议 日志 重跑
run_tests_with_coverage 1h22m PR问题:新增代码覆盖率 0%,2 行未覆盖,低于 80% 阈值 为 ep.py L46 和 fp8_utils.py L75 添加单测或申请豁免 Job -
其余 9 个必选任务通过 - - - - -

2.2 可选任务 — 29/31 通过

可选任务不阻塞合并,失败仅供参考。

状态 任务 耗时 日志 重跑
Check PR Template 12s Job -
⏸️ CI_HPU - - -
其余 29 个可选任务通过 - - -

3 失败详情(仅 required)

Run FastDeploy Unit Tests and Coverage / run_tests_with_coverage — 代码覆盖率不达标(置信度: 高)

Run FastDeploy Unit Tests and Coverage / run_tests_with_coverage

  • 状态: ❌ 失败
  • 错误类型: 代码覆盖率不达标
  • 置信度: 高
  • 根因摘要: 新增代码覆盖率 0%,2 行未覆盖,低于 80% 阈值
  • 分析器: ci_analyze_unittest_fastdeploy

根因详情:
PR 修改了 fastdeploy/model_executor/layers/moe/ep.py(第 46 行)和 fastdeploy/model_executor/layers/quantization/fp8_utils.py(第 75 行),共 2 行变更代码均未被单元测试覆盖,diff 覆盖率为 0%,低于 80% 的门槛(COVERAGE_EXIT_CODE: 9)。所有单元测试本身均通过(TEST_EXIT_CODE: 0)。

关键日志:

COVERAGE_EXIT_CODE: 9
GPU Patch Coverage Details:
{
  "total_num_lines": 2, "total_num_violations": 2, "total_percent_covered": 0,
  "fastdeploy/model_executor/layers/moe/ep.py": {"percent_covered": 0.0, "violation_lines": [46]},
  "fastdeploy/model_executor/layers/quantization/fp8_utils.py": {"percent_covered": 0.0, "violation_lines": [75]}
}
##[error]Process completed with exit code 9.

修复建议:

  1. fastdeploy/model_executor/layers/moe/ep.py L46 增加单元测试覆盖该行逻辑
  2. fastdeploy/model_executor/layers/quantization/fp8_utils.py L75 增加单元测试覆盖该行逻辑
  3. 若以上代码行属于不可测试的分支(如硬件特定路径),可向团队申请覆盖率豁免

关联变更: fastdeploy/model_executor/layers/moe/ep.py L46, fastdeploy/model_executor/layers/quantization/fp8_utils.py L75

链接: 查看日志

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@1d82c5b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/model_executor/layers/moe/ep.py 0.00% 1 Missing ⚠️
...oy/model_executor/layers/quantization/fp8_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7859   +/-   ##
==========================================
  Coverage           ?   63.33%           
==========================================
  Files              ?      462           
  Lines              ?    64365           
  Branches           ?     9871           
==========================================
  Hits               ?    40765           
  Misses             ?    20832           
  Partials           ?     2768           
Flag Coverage Δ
GPU 72.44% <0.00%> (?)
XPU 7.12% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants