Add nautilus to type of entities to send updated equipment data #13476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancelled interactions cause desync with nautilus armor/saddles
Warriorrrr
approved these changes
Dec 31, 2025
Contributor
|
This kinda overlap with #13013, also the comment is outdated. |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Contributor
Author
|
I will go ahead and close this one out. #13013 would indeed resolve the presented issue. If there is reason to include more than just horses and nautilus, works for me. Wasn't sure that we necessarily wanted to re-send out equipment data for all cancelled entity interactions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancelled interactions cause desync with nautilus armor/saddles. So simply added them alongside horses where the entity equipment is resynced on cancelled interactions. There is a general lack of interface/etc that ties these types of entities together. The only thing internally is
HasCustomInventoryScreenBut that isn't really appropriate and would over-contain chest boats.This fix does resolve the desync I experience when I cancel shearing or placing equipment on Nautilus.
Let me know if you think there should be any adjustments to this PR.