Add zip error reporting to PaperPluginClassLoader, too #13505
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owen1212055
reviewed
Jan 4, 2026
| try { | ||
| entry = this.jar.getJarEntry(path); | ||
| } catch (IllegalStateException zipFileClosed) { | ||
| String pluginName = Objects.requireNonNullElse(configuration.getName(), "<uninit>"); |
Member
There was a problem hiding this comment.
Dont think getName can ever be null, otherwise lgtm
Contributor
Author
There was a problem hiding this comment.
It's not set in the constructor, and for purposes of future-proofing and debugging, I would never want to make a classloading error worse to debug than it already is.
Member
There was a problem hiding this comment.
if somebody puts null there, which really isnt possible, things will blow up A LOT easier
Owen1212055
approved these changes
Jan 4, 2026
lynxplay
approved these changes
Jan 4, 2026
github-project-automation
bot
moved this from Awaiting review
to Merged
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an analogue to #12580 , but for Paper plugin classloaders.
More debug info can never hurt, and besides, the same rationale holds as for that PR.