feat(api): Add pages-only constructor to BookImpl#1372
Merged
kezz merged 2 commits intoPaperMC:main/5from Apr 28, 2026
Merged
Conversation
Privatech38
changed the title
Member
|
This is useless without an associated change to the book interface |
Contributor
Author
|
@kezz implemeted the creation methods |
fix: BookImpl's pages constructor not being final feat: Add pages-only creation methods to Books API feat: Add pages-only constructor
Privatech38
force-pushed
the
feat/book-author
branch
from
e19c943 to
72c514c
Compare
kashike
previously requested changes
Feb 21, 2026
Member
|
Thanks for the PR! Just made a few changes to simplify a bit of the logic here. |
kezz
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1348