Add support for Baryanic Leylines (Disciple of Varashta)#1804
Conversation
awlego
force-pushed
the
baryanic-leylines
branch
2 times, most recently
from
711d527 to
ae99b0c
Compare
|
Updated the PR with the latest so modcache should be up to date as well as did some polish around the tooltip. |
|
|
|
@LocalIdentity let me know if there are any requested changes or if there is someone I should add for a review. |
|
I'll out for the next two weeks, but if there are any requested changes I'll address them when I return. |
|
Hey @awlego, thanks so much for putting all this together! I started to make these changes today when I was directed to your PR. I forked it and looked over the conflicts. It seems the dev branch had someone clean up the jewel code logic in ModParser.lua, which was simple enough to adapt to your new code. I fixed the commit issues locally and pushed the updated branch here: https://github.com/bstassel/PathOfBuilding-PoE2/tree/pr-1804 The Docker test suite passes locally with: 422 successes / 0 failures / 0 errors / 0 pending Would you be willing to pull or cherry-pick these changes into this PR? I’m also happy to open a separate PR if that would be easier. |
Parse "Non-Unique Time-Lost Jewels have X% increased radius" into a NonUniqueTimeLostJewelRadius modifier. When the build has the modifier, non-unique Time-Lost Jewels swap to a precomputed +40% radius tier for the in-radius passive computation and for the socket ring drawn on the tree. Regenerated ModCache.lua accordingly.
- Append "(+X% from tree)" to the jewel tooltip Radius line when a build has NonUniqueTimeLostJewelRadius active. - Skip Time-Lost upgrade radius indexes in the AddNodeTooltip probe set unless the build actually has access to them, avoiding unnecessary ProcessStats calls per hover.
awlego
force-pushed
the
baryanic-leylines
branch
from
ae99b0c to
3fbb50f
Compare
- Regenerated the NonUniqueTimeLostJewelRadius entry in ModCache.lua against 0.5.3 data so it no longer carries the stale Offering SkillType enum from the pre-0.5.3 base. - Removed a duplicate `local effectiveRadiusIndex` declaration (and stray double space) in PassiveTreeView drawJewelRadius.
awlego
force-pushed
the
baryanic-leylines
branch
from
3fbb50f to
66deb55
Compare
|
Hey @bstassel I'm happy to pull yours in. |
3 participants
Description of the problem being solved:
Adds support for Baryanic Leylines (Disciple of Varashta). The tree entry for "Non-Unique Time-Lost Jewels have 40% increased radius" existed but had no parser, so allocating the notable did nothing.
ModParser.luaparses the stat into aNonUniqueTimeLostJewelRadiusINC mod.Data.luaadds four precomputed +40% radius tiers plus aresolveTimeLostRadiusIndexhelper keyed by percent.CalcSetup.luaandPassiveTreeView.luacall the helper so in-radius calcs, the socket ring, and node tooltips all use the upgraded radius on non-unique Time-Lost jewels.ModCache.luaregenerated; new spec added.Steps taken to verify a working solution:
devbranch plus this change, picked a Sorceress, allocated Disciple of Varashta → Baryanic Leylines.NonUniqueTimeLostJewelRadius INC 40Small Passives in Radius also grant X%roll into an allocated jewel socket; recorded which passives it affected before allocating Baryanic Leylines.TestBaryanicLeylines_spec.luaLink to a build that showcases this PR:
Before screenshot:
(without Baryonic Leylines)
(with Baryonic Leylines)
(and a before shot of a passive outside the ring)
After screenshot:
Showing that the Baryanic Leylines node shows that it is supported and the effects it will have on the build.
Same build/view on this branch, ring now visibly expanded and a previously-unaffected passive showing the jewel's inherited stats in its tooltip.