Buy similar: fix mod matching and improve search workflow#1942
Merged
LocalIdentity merged 39 commits intoMay 25, 2026
Conversation
…currency rates
…ate limiting waits if possible
…lems, and to show it on non-429 rate limit. (429 issue solved on GGG's side)
…earch tries to add results to controls
…shes in a similar format as previous mod export changes.
LocalIdentity
approved these changes
May 25, 2026
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…dingCommunity#1942) * port compatible trader tool changes from pob1 * Fix corrupted mods being fractured mods in trade mod generation * Fix radius jewel weight generation * Regenerate QueryMods.lua * convert trade tool mod weight generation to use tradeHash * wip: change poesessid to bearer token * Cleanup: remove extra logout button and fix poeapi comments * Fix trader crash when rate limited on startup * Use https://poe.ninja/poe2/api/economy/exchange/current/overview for currency rates * Fix poe.ninja tests * Fix trader section anchor * Adjust price scaling factor due to things being in divs (still an abitrary number) * Clarify price options and rate limit waits, and use Retry-After for rate limiting waits if possible * rate limiting pls work * Fix perfect essences not appearing in generated weights, and regenerate querymods.lua * Fix tradehashes for radius jewels * Improve rate limit countdown to prevent simplegraphic suspension problems, and to show it on non-429 rate limit. (429 issue solved on GGG's side) * Fix debug print causing crash, and remove extra debug print * disable wiping trader controls to fix crash when it is closed and a search tries to add results to controls * remove whisper for instant buyout items * make cspell happy * Fix currency conversion button not being updated after reopening trader panel * Avoid useless search in "search for" button * fix api error on invalid token * disable reuseaddr * Remove error code on login and fix hanging item slot controls in tradequery * Fix QueryMods.lua generation. Change soulcores.lua to export trade hashes in a similar format as previous mod export changes. * Add note about trade hashes * Clear authorization on 403 to fix outdated scope in trader * Use enum in mods.lua and format it * Fix typo in mods.lua * Remove forgotten debug prints * Fix trade hash generation * add note about radius jewel mods * Fix rune weight generation and regenerate QueryMods.lua * Port buy similar improvements from pob1 and improve mod matching * Fix timeless jewel searching (completely useless) * Fix error handling on oauth login * Spacing --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This ports PathOfBuildingCommunity/PathOfBuilding#9857 and fixes any remaining mod mismatches. As far as I can see, every mod matches correctly now.
Steps taken to verify a working solution:
Be careful when testing with poe.ninja profiles. There was a bug that causes enchants to be exported as implicits. This breaks the mod matching here due to the trade site matching affixes by implicit and enchant separately. This has since been fixed, but since the league is dead, most profiles haven't been refreshed.
Link to a build that showcases this PR:
A bunch of random builds:
See linked PR for screenshots.
Depends on #1801